Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SSP-2100] added more verbose error messages when using logException on SF #3018

Merged
merged 2 commits into from Feb 13, 2024
Merged

[SSP-2100] added more verbose error messages when using logException on SF #3018

merged 2 commits into from Feb 13, 2024

Conversation

sebaholesz
Copy link
Contributor

@sebaholesz sebaholesz commented Feb 8, 2024 •
edited by github-actions bot

Q A
Description, reason for the PR With the current Sentry logging on SF, there were many generic and undistinguishable messages. This PR adds more context to each message, making it easier to debug using Sentry and thus fix bugs.
New feature No
BC breaks No
Fixes issues ...
Have you read and signed our License Agreement for contributions? Yes

馃寪 Live Preview:

@sebaholesz sebaholesz added Enhancement New feature or request for change from user point of view DX & Refactoring Requests for DX improvements and refactorings labels Feb 8, 2024
@sebaholesz sebaholesz self-assigned this Feb 8, 2024
@sebaholesz sebaholesz force-pushed the sh-ssp-2100-sf-sentry-messages-improvements branch from b41884f to cd1d380 Compare February 8, 2024 11:09
@sebaholesz sebaholesz force-pushed the sh-ssp-2100-sf-sentry-messages-improvements branch 2 times, most recently from af8f535 to 67f6240 Compare February 12, 2024 15:24
@sebaholesz sebaholesz force-pushed the sh-ssp-2100-sf-sentry-messages-improvements branch from 67f6240 to d743e0e Compare February 13, 2024 08:31
@sebaholesz sebaholesz merged commit ed90d5b into 14.0 Feb 13, 2024
17 checks passed
@sebaholesz sebaholesz deleted the sh-ssp-2100-sf-sentry-messages-improvements branch February 13, 2024 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pk16011990 pk16011990 pk16011990 approved these changes

@tvikito tvikito tvikito approved these changes

Assignees

@sebaholesz sebaholesz

Labels
DX & Refactoring Requests for DX improvements and refactorings Enhancement New feature or request for change from user point of view
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@sebaholesz @pk16011990 @tvikito