Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix of the framework package #3029

Merged
merged 3 commits into from Feb 16, 2024
Merged

fix of the framework package #3029

merged 3 commits into from Feb 16, 2024

Conversation

vitek-rostislav
Copy link
Contributor

@vitek-rostislav vitek-rostislav commented Feb 16, 2024 •
edited by github-actions bot

Q A
Description, reason for the PR After merging #2952 and splitting the monorepo, some checks in the framework package failed pointing out a problem with namespace and DB migration
New feature No
BC breaks No
Fixes issues ...
Have you read and signed our License Agreement for contributions? Yes

馃寪 Live Preview:

grossmannmartin
grossmannmartin requested changes Feb 16, 2024
View reviewed changes
Copy link
Member

@grossmannmartin grossmannmartin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you please check the packages/framework/src/Model/Payment/PaymentRepository.php? I see App namespace there too (line 141).

Also in frontend-api AdvertImagesQuery, ProductImagesQuery, PriceQuery, ProductEntityFieldMapper

@vitek-rostislav vitek-rostislav merged commit ef4b3c6 into 14.0 Feb 16, 2024
17 checks passed
@vitek-rostislav vitek-rostislav deleted the rv-fix-after-split branch February 16, 2024 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grossmannmartin grossmannmartin grossmannmartin approved these changes

@TomasLudvik TomasLudvik TomasLudvik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@vitek-rostislav @grossmannmartin @TomasLudvik