-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[project-base] [SSP-2146] cypress tests extra scenarios #3052
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sebaholesz
force-pushed
the
sh-ssp-2146-cypress-tests-extra-scenarios
branch
from
May 3, 2024 09:55
077e132
to
ac86c25
Compare
sebaholesz
changed the title
[WIP] [SSP-2146] cypress tests extra scenarios
[project-base] [SSP-2146] cypress tests extra scenarios
May 3, 2024
sebaholesz
added
Documentation
Something needs documentation or documentation is not clear or correct
DX & Refactoring
Requests for DX improvements and refactorings
labels
May 3, 2024
sebaholesz
force-pushed
the
sh-ssp-2146-cypress-tests-extra-scenarios
branch
10 times, most recently
from
May 7, 2024 05:30
d70fc32
to
d324dd2
Compare
TomasLudvik
approved these changes
May 7, 2024
project-base/storefront/cypress/e2e/authentication/registration.cy.ts
Outdated
Show resolved
Hide resolved
sebaholesz
force-pushed
the
sh-ssp-2146-cypress-tests-extra-scenarios
branch
12 times, most recently
from
May 10, 2024 15:37
2f27ee7
to
1ef310a
Compare
sebaholesz
force-pushed
the
sh-ssp-2146-cypress-tests-extra-scenarios
branch
from
May 11, 2024 09:28
0db3242
to
1ef310a
Compare
grossmannmartin
force-pushed
the
sh-ssp-2146-cypress-tests-extra-scenarios
branch
from
May 13, 2024 06:00
a3732f0
to
ca0742e
Compare
- the visibility and value of promocode is now correctly initialized - removed transition around promo code input, which caused the UI to break (not display though it should) - this allowed for the package to be removed altogether
- added generic typing to useForwarderRef - minus and plus buttons are disabled when they cannot be used - state had to be implemented to map spinbox value in order to enforce re-renders
- all actions inside tests now have descriptive names - snapshots now use test name + suffix - removed unused blocks of code - cypress tests now allow to hide parts of UI for screenshots - cypress tests now allow to take screenshots of specific elements - cypress tests now scroll up and down the page before screenshots to load lazy-loaded images
- this is because during login and logout process, we do not know the state of the user's cart - we thus wait until auth loading finishes and then perform necessary redirects
- these images with unpredictable and broken sizes were problematic not only for cypress tests, but also looked incorrect on the website
- it was not necessary anymore, as running it through docker already fixes the problem
- page refresh events are now broadcasted before reloading the current browser tab - current browser tab now ignores the broadcasted message
sebaholesz
force-pushed
the
sh-ssp-2146-cypress-tests-extra-scenarios
branch
from
May 13, 2024 14:20
ca0742e
to
82c5994
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Documentation
Something needs documentation or documentation is not clear or correct
DX & Refactoring
Requests for DX improvements and refactorings
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🌐 Live Preview: