Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[project-base] [SSP-2146] cypress tests extra scenarios #3052

Merged
merged 13 commits into from
May 13, 2024

Conversation

sebaholesz
Copy link
Contributor

@sebaholesz sebaholesz commented Mar 2, 2024

Q A
Description, reason for the PR Before order refactoring, we wanted to implement a robust suite of tests, so we can be more sure while changing the code. This PR extends the test suite, refactors tests for better DX, and fixes bugs along the way.
New feature No
BC breaks No
Fixes issues ...
Have you read and signed our License Agreement for contributions? Yes

🌐 Live Preview:

@sebaholesz sebaholesz force-pushed the sh-ssp-2146-cypress-tests-extra-scenarios branch from 077e132 to ac86c25 Compare May 3, 2024 09:55
@sebaholesz sebaholesz changed the title [WIP] [SSP-2146] cypress tests extra scenarios [project-base] [SSP-2146] cypress tests extra scenarios May 3, 2024
@sebaholesz sebaholesz self-assigned this May 3, 2024
@sebaholesz sebaholesz added Documentation Something needs documentation or documentation is not clear or correct DX & Refactoring Requests for DX improvements and refactorings labels May 3, 2024
@sebaholesz sebaholesz force-pushed the sh-ssp-2146-cypress-tests-extra-scenarios branch 10 times, most recently from d70fc32 to d324dd2 Compare May 7, 2024 05:30
@sebaholesz sebaholesz force-pushed the sh-ssp-2146-cypress-tests-extra-scenarios branch 12 times, most recently from 2f27ee7 to 1ef310a Compare May 10, 2024 15:37
@sebaholesz sebaholesz enabled auto-merge May 10, 2024 15:47
@sebaholesz sebaholesz force-pushed the sh-ssp-2146-cypress-tests-extra-scenarios branch from 0db3242 to 1ef310a Compare May 11, 2024 09:28
@grossmannmartin grossmannmartin force-pushed the sh-ssp-2146-cypress-tests-extra-scenarios branch from a3732f0 to ca0742e Compare May 13, 2024 06:00
- the visibility and value of promocode is now correctly
initialized
- removed transition around promo code input, which
caused the UI to break (not display though it should)
- this allowed for the package to be removed altogether
- added generic typing to useForwarderRef
- minus and plus buttons are disabled when they cannot be used
- state had to be implemented to map spinbox value in order to
enforce re-renders
- all actions inside tests now have descriptive names
- snapshots now use test name + suffix
- removed unused blocks of code
- cypress tests now allow to hide parts of UI for
screenshots
- cypress tests now allow to take screenshots of specific
elements
- cypress tests now scroll up and down the page before
screenshots to load lazy-loaded images
- this is because during login and logout process, we do not
know the state of the user's cart
- we thus wait until auth loading finishes and then perform
necessary redirects
- these images with unpredictable and broken sizes were
problematic not only for cypress tests, but also looked
incorrect on the website
- it was not necessary anymore, as running it through
docker already fixes the problem
- page refresh events are now broadcasted before reloading
the current browser tab
- current browser tab now ignores the broadcasted message
@sebaholesz sebaholesz force-pushed the sh-ssp-2146-cypress-tests-extra-scenarios branch from ca0742e to 82c5994 Compare May 13, 2024 14:20
@sebaholesz sebaholesz merged commit 97aec68 into 15.0 May 13, 2024
16 of 17 checks passed
@sebaholesz sebaholesz deleted the sh-ssp-2146-cypress-tests-extra-scenarios branch May 13, 2024 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation Something needs documentation or documentation is not clear or correct DX & Refactoring Requests for DX improvements and refactorings
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants