Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[framework] remove enums from the packages #3073

Merged
merged 7 commits into from Apr 8, 2024
Merged

[framework] remove enums from the packages #3073

merged 7 commits into from Apr 8, 2024

Conversation

vitek-rostislav
Copy link
Contributor

@vitek-rostislav vitek-rostislav commented Mar 18, 2024 •
edited by github-actions bot

Q A
Description, reason for the PR It is not possible to extend PHP enums (see https://www.php.net/manual/en/language.enumerations.object-differences.inheritance.php) so we should avoid their usage in the Shopsys packages that are meant to be extended
New feature No
BC breaks No
Fixes issues ...
Have you read and signed our License Agreement for contributions? Yes

馃寪 Live Preview:

@vitek-rostislav vitek-rostislav force-pushed the rv-goodbye-enums branch 4 times, most recently from 0ba8f28 to 32e3525 Compare March 26, 2024 10:21
TomasLudvik
TomasLudvik requested changes Mar 27, 2024
View reviewed changes
packages/framework/src/Component/Reflection/ReflectionHelper.php Show resolved Hide resolved
project-base/app/schema.graphql Outdated Show resolved Hide resolved
UPGRADE-14.0.md Outdated Show resolved Hide resolved
@vitek-rostislav vitek-rostislav force-pushed the rv-goodbye-enums branch 3 times, most recently from 3f42c88 to a2488c9 Compare April 2, 2024 17:51
@vitek-rostislav vitek-rostislav merged commit 1791b0b into 14.0 Apr 8, 2024
16 of 17 checks passed
@vitek-rostislav vitek-rostislav deleted the rv-goodbye-enums branch April 8, 2024 10:04
@vitek-rostislav vitek-rostislav mentioned this pull request Apr 11, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TomasLudvik TomasLudvik TomasLudvik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@vitek-rostislav @TomasLudvik