[Luigi's Box] recommended products #3099
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TomasLudvik
added
the
Enhancement
TomasLudvik
force-pushed
the
tl-luigis-box-recommendations
branch
2 times, most recently
from
6aec684
to
bf6f848
Compare
vitek-rostislav
requested changes
Apr 11, 2024
packages/luigis-box/src/Component/LuigisBox/LuigisBoxClient.php
Outdated
Show resolved
Hide resolved
packages/luigis-box/src/FrontendApi/Resolver/Recommendation/RecommendationQuery.php
Outdated
Show resolved
Hide resolved
packages/luigis-box/src/FrontendApi/Resolver/Recommendation/RecommendationQuery.php
Outdated
Show resolved
Hide resolved
packages/luigis-box/src/Resources/config/graphql-types/RecommendationType.types.yaml
Outdated
Show resolved
Hide resolved
TomasLudvik
force-pushed
the
tl-luigis-box-recommendations
branch
from
bf6f848
to
b0f049a
Compare
vitek-rostislav
approved these changes
Apr 12, 2024
TomasLudvik
force-pushed
the
tl-luigis-box-recommendations
branch
3 times, most recently
from
b1a6bd2
to
37d4a13
Compare
sebaholesz
force-pushed
the
tl-luigis-box-recommendations
branch
from
aa961f7
to
0119337
Compare
tvikito
reviewed
Apr 17, 2024
project-base/storefront/components/Blocks/Product/AddToCartPopup.tsx
Outdated
Show resolved
Hide resolved
project-base/storefront/components/Blocks/Product/ProductsList/ProductListItem.tsx
Outdated
Show resolved
Hide resolved
project-base/storefront/components/Blocks/Product/ProductsList/ProductsListContent.tsx
Outdated
Show resolved
Hide resolved
project-base/storefront/components/Pages/ProductDetail/ProductDetailContent.tsx
Outdated
Show resolved
Hide resolved
TomasLudvik
force-pushed
the
tl-luigis-box-recommendations
branch
from
ed310c8
to
3ffff35
Compare
sebaholesz
force-pushed
the
tl-luigis-box-recommendations
branch
from
3ffff35
to
f6c7b60
Compare
TomasLudvik
force-pushed
the
tl-luigis-box-recommendations
branch
2 times, most recently
from
902bb82
to
8b5a743
Compare
sebaholesz
force-pushed
the
tl-luigis-box-recommendations
branch
2 times, most recently
from
8731770
to
b82c12d
Compare
tvikito
reviewed
Apr 24, 2024
project-base/storefront/components/Blocks/Product/AddToCartPopup.tsx
Outdated
Show resolved
Hide resolved
project-base/storefront/helpers/serverSide/initServerSideProps.ts
Outdated
Show resolved
Hide resolved
sebaholesz
force-pushed
the
tl-luigis-box-recommendations
branch
2 times, most recently
from
02af6c6
to
9f1df55
Compare
sebaholesz
force-pushed
the
tl-luigis-box-recommendations
branch
2 times, most recently
from
163cd1c
to
0ae8818
Compare
tvikito
approved these changes
Apr 25, 2024
…secutive renders - this was necessary in order to have cookie-store-saved values available on the server immediately, and to have it synced with the client
- this is controlled by 2 new env variables (IS_LUIGIS_BOX_ACTIVE_DOMAIN_1, IS_LUIGIS_BOX_ACTIVE_DOMAIN_2) - LB recommended products are used instead of promoted products on HP if LB is active - ProductsSlider now accepts isMiniSlider prop, which decreases the number of slides and removes certain parts from the product card
…e quantity changes - this might happen if a product is added from cart page
- popup and overlay now stop propagation of mouse events, which was necessary, because some scroll and drag events were propagated to the content behind the popup, which worsened the UX - portal component now removes any previous content before mounting new one, which is helpful if a popup is opened while another one is already open and visible - when overlay is active, we set overflow on the body element to hidden so that it is not possible to scroll the website while an overlay is active
sebaholesz
force-pushed
the
tl-luigis-box-recommendations
branch
from
0061baf
to
58825b5
Compare
- now the approach we use it to modify the global state which stores the current portal content - because of this, we do not need to have local state with popup data, but instead synchronously call functions which update portal content and thus trigger rendering - useErrorPopupVisibility was renamed to useErrorPopup which now does not return anything but handles popup displaying by itself
…the server and only behaves as a dynamic state on the client
sebaholesz
force-pushed
the
tl-luigis-box-recommendations
branch
from
58825b5
to
492d8b9
Compare
sebaholesz
force-pushed
the
tl-luigis-box-recommendations
branch
from
492d8b9
to
3aa0a08
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🌐 Live Preview: