[framework] messenger: prevent errors when MESSENGER_TRANSPORT_DSN is empty #3114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vitek-rostislav
force-pushed
the
rv-data-fixtures-email
branch
from
e6095ba
to
c91ea95
Compare
TomasLudvik
approved these changes
Apr 19, 2024
- the DSN is set to an empty string in data fixtures so the messages are not sent in vain - see 794fc22 - the original solution with NullMessageBus was effective only if our message dispatcher was used, however, it was not working for dispatching emails as this is handled by Symfony dispatcher
vitek-rostislav
force-pushed
the
rv-data-fixtures-email
branch
from
c91ea95
to
b98b14c
Compare
pk16011990
approved these changes
Apr 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NullMessageBuswas effective only if our message dispatcher was used, however, it was not working for dispatching emails as this is handled by Symfony dispatcherNote: the first commit was cherry-picked from #3053
馃寪 Live Preview: