Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[frontend-api] applied promo code is now taken into account in priceByTransportQuery and priceByPaymentQuery #3118

Merged
merged 2 commits into from Apr 24, 2024
Merged

[frontend-api] applied promo code is now taken into account in priceByTransportQuery and priceByPaymentQuery #3118

merged 2 commits into from Apr 24, 2024

Conversation

vitek-rostislav
Copy link
Contributor

@vitek-rostislav vitek-rostislav commented Apr 19, 2024 •
edited by github-actions bot

Q A
Description, reason for the PR Transport and payment price is affected by total products price (including discounts) as there might be limit for free transport and payment. However, the promo code was omitted when the transport/payment price was calculated
New feature No
BC breaks No
Fixes issues ...
Have you read and signed our License Agreement for contributions? Yes

🌐 Live Preview:

@vitek-rostislav vitek-rostislav force-pushed the rv-free-transport branch 2 times, most recently from 2ee1ed6 to b93417d Compare April 23, 2024 19:23
@vitek-rostislav vitek-rostislav merged commit 784888e into 14.0 Apr 24, 2024
17 checks passed
@vitek-rostislav vitek-rostislav deleted the rv-free-transport branch April 24, 2024 10:47
@vitek-rostislav vitek-rostislav added the Bug Something isn't working label Apr 24, 2024
vitek-rostislav added a commit that referenced this pull request May 2, 2024
@vitek-rostislav
FE API: applied promo code is now taken into account in priceByTransp…
9cd8fbe 
…ortQuery and priceByPaymentQuery

- ported to v15.0 from #3118
@vitek-rostislav vitek-rostislav mentioned this pull request May 2, 2024
Merged
ShopsysBot pushed a commit to shopsys/frontend-api that referenced this pull request May 2, 2024
@vitek-rostislav
FE API: applied promo code is now taken into account in priceByTransp…
5c148e5 
…ortQuery and priceByPaymentQuery

- ported to v15.0 from shopsys/shopsys#3118
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grossmannmartin grossmannmartin grossmannmartin approved these changes

Assignees
No one assigned
Labels
Bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@vitek-rostislav @grossmannmartin