Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[frontend-api] addProductToListMutation: ensure new product list is created with non-conflicting uuid #3126

Merged
merged 2 commits into from Apr 24, 2024
Merged

[frontend-api] addProductToListMutation: ensure new product list is created with non-conflicting uuid #3126

merged 2 commits into from Apr 24, 2024

Conversation

vitek-rostislav
Copy link
Contributor

@vitek-rostislav vitek-rostislav commented Apr 23, 2024 •
edited by github-actions bot

Q A
Description, reason for the PR When a customer user is logged out due to the long inactivity, his product list uuids might be kept in the storage, and adding products to the list fails. Therefore, when an anonymous product list with a given uuid is not found, we still need to check whether a customer user's product list with the given uuid exists. If so, a new anonymous product list must be created with another uuid to avoid unique constraint violations. The same applies when the customer user's product list is not found by the given uuid -> we need to check for the existence of an anonymous list with the uuid before creating the new customer user's list
New feature No
BC breaks No
Fixes issues ...
Have you read and signed our License Agreement for contributions? Yes

🌐 Live Preview:

@vitek-rostislav vitek-rostislav added the Bug Something isn't working label Apr 23, 2024
@vitek-rostislav
FE API addProductToListMutation: ensure new product list is created w…
1ac00f4 
…ith non-conflicting uuid

- when anonymous product list with given uuid is not found, we still need to check whether a customer user's product list with the given uuid exists.
If so, new anonymous product list must be created with another uuid to avoid unique constraint violation.
- the same applies when customer user's product list is not found by the
  given uuid -> we need to check for existence of anonymous list with
the uuid before creating the new customer user's list
@vitek-rostislav
add upgrade notes
8693bde
@vitek-rostislav vitek-rostislav merged commit 1f4caf9 into 14.0 Apr 24, 2024
17 checks passed
@vitek-rostislav vitek-rostislav deleted the rv-product-list-fix branch April 24, 2024 11:53
@vitek-rostislav vitek-rostislav mentioned this pull request Apr 24, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grossmannmartin grossmannmartin grossmannmartin approved these changes

Assignees
No one assigned
Labels
Bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@vitek-rostislav @grossmannmartin