Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[shopsys] fix app class used outside of project base #3173

Merged
merged 1 commit into from
May 23, 2024
Merged

[shopsys] fix app class used outside of project base #3173

merged 1 commit into from
May 23, 2024

Conversation

AndrejBlaho
Copy link
Contributor

@AndrejBlaho AndrejBlaho commented May 22, 2024 •
edited by github-actions bot
Loading

Q A
Description, reason for the PR There was /App class used in framework package which is not allowed outside of project base, causing package tests to fail after monorepo split.
New feature No
BC breaks No
Fixes issues ...
Have you read and signed our License Agreement for contributions? Yes

🌐 Live Preview:

@AndrejBlaho AndrejBlaho force-pushed the ab-fix-iterative-image-sitemap branch 5 times, most recently from d366e66 to 49c549f Compare May 23, 2024 07:53
@AndrejBlaho AndrejBlaho force-pushed the ab-fix-iterative-image-sitemap branch from 49c549f to 00b7420 Compare May 23, 2024 12:30
@AndrejBlaho AndrejBlaho enabled auto-merge (squash) May 23, 2024 12:30
@AndrejBlaho AndrejBlaho merged commit e6ebce3 into 15.0 May 23, 2024
17 checks passed
@AndrejBlaho AndrejBlaho deleted the ab-fix-iterative-image-sitemap branch May 23, 2024 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vitek-rostislav vitek-rostislav vitek-rostislav approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@AndrejBlaho @vitek-rostislav