Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[shopsys] easier mail template extending #3232

Merged
merged 3 commits into from
Jul 1, 2024
Merged

[shopsys] easier mail template extending #3232

merged 3 commits into from
Jul 1, 2024

Conversation

AndrejBlaho
Copy link
Contributor

@AndrejBlaho AndrejBlaho commented Jun 19, 2024 •
edited by github-actions bot
Loading

Q A
Description, reason for the PR Setting variables for e-mail templates was nested inside of methods where these variables were already propagated for further processing. This resulted into inconvenient extending if something needed tobe changed so we moved variable setting into separate methods.
New feature No
BC breaks No
Fixes issues closes #1847
Have you read and signed our License Agreement for contributions? Yes

🌐 Live Preview:

@AndrejBlaho AndrejBlaho self-assigned this Jun 19, 2024
@AndrejBlaho AndrejBlaho added the DX & Refactoring Requests for DX improvements and refactorings label Jun 19, 2024
@AndrejBlaho AndrejBlaho force-pushed the ab-easier-mail-template-extending branch 2 times, most recently from c5fee24 to 7dc2cc5 Compare June 19, 2024 06:45
@AndrejBlaho AndrejBlaho force-pushed the ab-easier-mail-template-extending branch from 6aacfe9 to cfb49d8 Compare June 28, 2024 11:15
@AndrejBlaho AndrejBlaho force-pushed the ab-easier-mail-template-extending branch from cfb49d8 to 3ea95f4 Compare July 1, 2024 07:09
@AndrejBlaho AndrejBlaho merged commit 797a0a8 into 15.0 Jul 1, 2024
17 checks passed
@AndrejBlaho AndrejBlaho deleted the ab-easier-mail-template-extending branch July 1, 2024 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grossmannmartin grossmannmartin grossmannmartin approved these changes

Assignees

@AndrejBlaho AndrejBlaho

Labels
DX & Refactoring Requests for DX improvements and refactorings
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

it is hard to extend an existing mail template
2 participants
@AndrejBlaho @grossmannmartin