Category entity in constructor of CategoryRepository is resolved via EntityNameResolver #341
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Miroslav-Stopka
commented
Jul 23, 2018
•
Miroslav-Stopka
commented
- Category entity is now extendable and extraction of class metadata are loaded from an extended entity if exists
| Q | A |
|---|---|
| Description, reason for the PR | Class metadata for GedmoTree are not available in extended Category entity |
| New feature | No |
| BC breaks | No |
| Fixes issues | ... |
| Standards and tests pass | Yes |
| Have you read and signed our License Agreement for contributions? | Yes |
|
Hello @Miroslav-Stopka, thank you for your PR. This is a nice job I like it a lot. Please update your CM slightly and I will be able to accept this. Category entity in the constructor of CategoryRepository is resolved via EntityNameResolver
|
Miroslav-Stopka
force-pushed
the
msa-category-extendible
branch
from
2b680f2
to
15f1839
Compare
|
Done :) Can you confirm? Thank you. |
TomasLudvik
changed the title
TomasLudvik
approved these changes
Jul 27, 2018
|
I have tested it and it is even working well, good job there @Miroslav-Stopka! |
LukasHeinz
reviewed
Jul 27, 2018
…via EntityNameResolver - Category entity is now extendable and extraction of class metadata are loaded from an extended entity if exists
TomasLudvik
force-pushed
the
msa-category-extendible
branch
from
15f1839
to
48910cc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.