Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

product search: fix wrong variable usage in url to reset filter #359

Merged
merged 1 commit into from Aug 13, 2018
Merged

product search: fix wrong variable usage in url to reset filter #359

merged 1 commit into from Aug 13, 2018

Conversation

jDolba
Copy link
Contributor

@jDolba jDolba commented Jul 26, 2018

  • variable name was used in url instead of variable value
Q A
Description, reason for the PR bugfix
New feature No
BC breaks No
Fixes issues -
Standards and tests pass Yes
Have you read and signed our License Agreement for contributions? Yes

simara-svatopluk
simara-svatopluk suggested changes Aug 3, 2018
View reviewed changes
Copy link
Contributor

@simara-svatopluk simara-svatopluk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!
I definitelly agree, this is a bug that have to be fixed.

May I ask You to add a note into CHANGELOG.md?
(under unreleased with a new sub-headline "shopsys/project-base")

@jDolba jDolba force-pushed the jd-wrong-search-parameter branch 2 times, most recently from 83841d6 to ba48ac1 Compare August 7, 2018 16:35
@jDolba
product search: fix wrong variable usage in url to reset filter
38d1cd2 
-  variable name was used in url instead of variable value
@jDolba
Copy link
Contributor Author

jDolba commented Aug 7, 2018

Hi @simara-svatopluk
note in change log was added (see files in this PR)

@simara-svatopluk
Copy link
Contributor

@jDolba Thanks! great job

@boris-brtan boris-brtan merged commit c49cfe1 into shopsys:master Aug 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simara-svatopluk simara-svatopluk simara-svatopluk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jDolba @simara-svatopluk @boris-brtan