Implemented completion aware interface for stecman symfony console completion #573
Conversation
|
I guess you missed the composer.json require for the stecman package |
|
Well I made it in the wrong composer.json. It is stuck in the development template 😆 |
|
I added the missing dependency |
JoshuaBehrens
force-pushed
the
feature-console-completion
branch
from
67aa330
to
4dd4bef
Compare
|
I added the dependency to the other repositories as well, implemented the feature for theme:change |
JoshuaBehrens
force-pushed
the
feature-console-completion
branch
from
4dd4bef
to
04ac8b5
Compare
|
Rebase is out and I also changed the new docs |
|
|
||
| return $result; | ||
| } elseif ($argumentName === 'namespace') { | ||
| // TODO find good way to determine the namespace |
There was a problem hiding this comment.
Hey @JoshuaBehrens,
will you still take care of that tone? :-)
There was a problem hiding this comment.
Good catch. I think by now it is easier for me to find namespaces :) I'll amend that
|
This PR was closed due to inactivity. If this change is still important to you, feel free to create a new pull request. |
1. Why is this change necessary?
For easier usability of console commands. This is a rebased follow up to #33
Did you ever recognized a whole uuid? Do you know by heart what the plugin was spelled?
Examples in usage were already shown in the pull request for shopware 5.
2. What does this change do, exactly?
Implements for all core/shipped commands the CompletionAwareInterface
Adds hints in the documentation
3. Describe each step to reproduce the issue or behaviour.
Press tab to complete your shopware console commands. It just does not work.
4. Which documentation changes (if any) need to be made because of this PR?
https://docs.shopware.com should get a hint on the setup and pros.
There is a complementary pull request to shopware/development#20 to ensure this features is ready in the default docker container.
5. Checklist