Skip to content
This repository has been archived by the owner on Oct 13, 2023. It is now read-only.

NEXT-9410 - Add target attribute to manufacturer link on product deta… #136

Merged
merged 1 commit into from
Sep 17, 2020

Conversation

t2oh4e
Copy link

@t2oh4e t2oh4e commented Sep 17, 2020

…il page. Fixes #15.

1. What does this change do, exactly?

Opens the link to the manufacturer page in a new tab.

2. Describe each step to reproduce the issue or behaviour.

Visit a product detail page with a manufacturer that has a website. Click on the link. Before this change it opens in the same tab and "closes" the shop. After the change it will be opened in a new tab. See: https://vimeo.com/458894191/b47607ba55

3. Checklist

  • I have written tests and verified that they fail without my change
  • I have squashed any insignificant commits
  • I have created a changelog file with all necessary information about my changes
  • I have written or adjusted the documentation according to my changes
  • This change has comments for package types, values, functions, and non-obvious lines of code
  • I have read the contribution requirements and fulfil them.

@PaddyS PaddyS self-requested a review September 17, 2020 09:23
@shyim shyim merged commit d236974 into master Sep 17, 2020
@shyim shyim deleted the NEXT-9410-add-target-to-manufacturer-link branch September 17, 2020 09:24
@timoreddig
Copy link

Adding rel="noopener" or rel="noreferrer" to your target="_blank" links avoids performance and security issue: https://web.dev/external-anchors-use-rel-noopener/

@t2oh4e t2oh4e restored the NEXT-9410-add-target-to-manufacturer-link branch September 17, 2020 14:19
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NEXT-9410 - Manufacturer Link in new Tab
4 participants