fix(shorebird_cli): camel case flavors can confuse path finding for android #1861
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you! This is going to require tests. |
bryanoltman
changed the title
added kebeb case in string extenstions and used in appbuble path in android command
bryanoltman
requested changes
Apr 5, 2024
bryanoltman
reviewed
Apr 8, 2024
| @@ -7,4 +7,11 @@ void main() { | |||
| expect(''.isNullOrEmpty, true); | |||
| expect('test'.isNullOrEmpty, false); | |||
| }); | |||
|
|
|||
| test('ToKebabCase', () async { | |||
There was a problem hiding this comment.
What does this do for text containing spaces?
There was a problem hiding this comment.
it wont make any change as of now, will make changes to convert space to hypen (-).
|
It looks like there are also some code formatting issues that need to be fixed. Edit: test/src/extensions/string_test.dart, from https://github.com/shorebirdtech/shorebird/actions/runs/8604701717/job/23579393323?pr=1861 |
bryanoltman
approved these changes
Apr 9, 2024
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added
kebeb-casein string extensions and used in appbundle path in android commandDescription
Ref : #1830
shorebird release androidcommand when passed with multi dimensional flavors, resulted in error since shorebird cant find the app bundle. It was due to the mismatch in file name path due to different case.The appbundle is created in kebab-case where as shorebird looks for filename in camelCase.
Type of Change