Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(shorebird_cli): remove early call to closeSync in extractZip #1884

Merged
merged 2 commits into from
Apr 9, 2024

Conversation

felangel
Copy link
Contributor

@felangel felangel commented Apr 9, 2024

Description

Type of Change

  • ✨ New feature (non-breaking change which adds functionality)
  • 🛠️ Bug fix (non-breaking change which fixes an issue)
  • ❌ Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 Code refactor
  • ✅ Build configuration change
  • 📝 Documentation
  • 🗑️ Chore

@felangel felangel self-assigned this Apr 9, 2024
Copy link

codecov bot commented Apr 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (d34507d) to head (c3b2742).

❗ Current head c3b2742 differs from pull request most recent head 2b06f15. Consider uploading reports for the commit 2b06f15 to get more accurate results

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #1884   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          173       173           
  Lines         5447      5446    -1     
=========================================
- Hits          5447      5446    -1     
Flag Coverage Δ
shorebird_cli 100.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@felangel felangel merged commit f7aa2a8 into main Apr 9, 2024
5 of 8 checks passed
@felangel felangel deleted the fix/remove-early-close-sync branch April 9, 2024 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants