feat(shorebird_cli): alert user of non-patchable changes #538
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
felangel
reviewed
May 24, 2023
felangel
reviewed
May 24, 2023
| Set<AabDifferences> aabContentDifferences(String aabPath1, String aabPath2) { | ||
| final fileDifferences = aabFileDifferences(aabPath1, aabPath2); | ||
|
|
||
| final hasAssetChanges = fileDifferences.any((file) { |
There was a problem hiding this comment.
minor but could we refactor to loop through the files once to determine what has changed?
There was a problem hiding this comment.
I've updated this code since this comment was written, but as it stands now, I worry that we'd losing quite a bit of readability for a negligible performance improvement. Happy to be shown otherwise though!
felangel
reviewed
May 24, 2023
felangel
reviewed
May 24, 2023
Closed
felangel
reviewed
May 24, 2023
felangel
reviewed
May 24, 2023
felangel
reviewed
May 24, 2023
felangel
reviewed
May 24, 2023
felangel
reviewed
May 24, 2023
packages/shorebird_cli/test/src/commands/patch_command_test.dart
Outdated
Show resolved
Hide resolved
felangel
reviewed
May 24, 2023
packages/shorebird_cli/test/src/commands/patch_command_test.dart
Outdated
Show resolved
Hide resolved
felangel
reviewed
May 24, 2023
packages/shorebird_code_push_client/lib/src/code_push_client.dart
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updates
shorebird patchto compare the contents of the aab generated during the patch build with the contents of the aab generated by the corresponding release.When a native code change is detected (i.e., a change to a
.dexfile), the patch command fails.When an asset change is detected, the patch command warns the user and asks if they are sure they want to continue.
Fixes #385
Type of Change