Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: shorebird should detect/warn about non-dart app changes #385

Closed
eseidel opened this issue Apr 27, 2023 · 1 comment · Fixed by #538
Closed

feat: shorebird should detect/warn about non-dart app changes #385

eseidel opened this issue Apr 27, 2023 · 1 comment · Fixed by #538
Assignees
@bryanoltman
Labels
tt trusted tester feedback

Comments

@eseidel
Copy link
Contributor

eseidel commented Apr 27, 2023

TTs have run into this. Both by changing flutter_assets as well as changing java/kotlin code.

We should detect that there have been changes to the app that we do not support patching and warn users.
@eseidel eseidel moved this to Todo in 0.1.0: Open beta Apr 27, 2023
@eseidel eseidel mentioned this issue Apr 30, 2023
Closed
@bryanoltman bryanoltman added the tt trusted tester feedback label May 1, 2023
@eseidel eseidel moved this from Todo to Unsure in 0.1.0: Open beta May 1, 2023
@eseidel eseidel moved this from Unsure to Todo in 0.1.0: Open beta May 5, 2023
@eseidel eseidel moved this from Todo to Punted in 0.1.0: Open beta May 9, 2023
@bartekpacia
Copy link

Hi! :)

I think you should also warn about plugin updates. I think that there's no way to know if a new version of some Flutter plugin made changes to the native code (that can't be updated by Shortbird). Unless you do some clever diffing.

@eseidel eseidel moved this to Todo in 0.2.1 : 100 users May 18, 2023
@bryanoltman bryanoltman self-assigned this May 23, 2023
@bryanoltman bryanoltman moved this from Todo to In Progress in 0.2.1 : 100 users May 23, 2023
@bryanoltman bryanoltman mentioned this issue May 24, 2023
Merged
7 tasks
@github-project-automation github-project-automation bot moved this from In Progress to Done in 0.2.1 : 100 users May 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bryanoltman bryanoltman

Labels
tt trusted tester feedback
Projects
No open projects
0.1.0: Open beta
Status: Punted
0.2.1 : 100 users
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(shorebird_cli): alert user of non-patchable changes shorebirdtech/shorebird
3 participants
@eseidel @bryanoltman @bartekpacia