Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(code_push_protocol)!: remove duplicate/deprecated fields #859

Merged
merged 4 commits into from
Jul 17, 2023

Conversation

felangel
Copy link
Contributor

Description

  • refactor(code_push_protocol): remove duplicate/deprecated fields

Type of Change

  • ✨ New feature (non-breaking change which adds functionality)
  • 🛠️ Bug fix (non-breaking change which fixes an issue)
  • ❌ Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 Code refactor
  • ✅ Build configuration change
  • 📝 Documentation
  • 🗑️ Chore

@felangel felangel self-assigned this Jul 17, 2023
@felangel felangel changed the title refactor(code_push_protocol): remove duplicate/deprecated fields refactor(code_push_protocol)!: remove duplicate/deprecated fields Jul 17, 2023
@codecov
Copy link

codecov bot commented Jul 17, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (dd14321) 100.00% compared to head (c7042d5) 100.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##              main      #859    +/-   ##
==========================================
  Coverage   100.00%   100.00%            
==========================================
  Files           77       145    +68     
  Lines         2731      3519   +788     
==========================================
+ Hits          2731      3519   +788     
Impacted Files Coverage Δ
...lib/src/messages/get_usage/get_usage_response.dart 100.00% <ø> (ø)
...b/src/messages/get_usage/get_usage_response.g.dart 100.00% <ø> (ø)
...ode_push_protocol/lib/src/models/subscription.dart 100.00% <ø> (ø)
...e_push_protocol/lib/src/models/subscription.g.dart 100.00% <ø> (ø)
...ib/src/commands/account/account_usage_command.dart 100.00% <100.00%> (ø)

... and 64 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@felangel felangel merged commit 3999b98 into main Jul 17, 2023
10 checks passed
@felangel felangel deleted the refactor/code-push-protocol-cleanup branch July 17, 2023 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants