Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(shorebird_cli): warn users of incomplete release when patching #876

Merged
merged 2 commits into from
Jul 20, 2023

Conversation

bryanoltman
Copy link
Contributor

Description

If the release being patched is in a "draft" state, inform the user and tell them how to proceed.

Part of #774

Type of Change

  • ✨ New feature (non-breaking change which adds functionality)
  • 🛠️ Bug fix (non-breaking change which fixes an issue)
  • ❌ Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 Code refactor
  • ✅ Build configuration change
  • 📝 Documentation
  • 🗑️ Chore

@codecov
Copy link

codecov bot commented Jul 19, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (c6a04c8) 100.00% compared to head (f22706c) 100.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##              main      #876    +/-   ##
==========================================
  Coverage   100.00%   100.00%            
==========================================
  Files          147        76    -71     
  Lines         3531      2730   -801     
==========================================
- Hits          3531      2730   -801     
Impacted Files Coverage Δ
...horebird_cli/lib/src/code_push_client_wrapper.dart 100.00% <100.00%> (ø)
..._cli/lib/src/commands/patch/patch_aar_command.dart 100.00% <100.00%> (ø)
.../lib/src/commands/patch/patch_android_command.dart 100.00% <100.00%> (ø)
..._cli/lib/src/commands/patch/patch_ios_command.dart 100.00% <100.00%> (ø)

... and 71 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@bryanoltman bryanoltman merged commit 5999fb3 into main Jul 20, 2023
7 checks passed
@bryanoltman bryanoltman deleted the bo/patch-draft branch July 20, 2023 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants