Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

switching to tox-travis and tox matrix #43

Merged
merged 1 commit into from
Jun 24, 2019
Merged

switching to tox-travis and tox matrix #43

merged 1 commit into from
Jun 24, 2019

Conversation

miki725
Copy link
Collaborator

@miki725 miki725 commented Jun 24, 2019 

  py27-dj11: commands succeeded
  py36-dj11: commands succeeded
  pypy-dj11: commands succeeded
  py36-dj20: commands succeeded
  py36-dj21: commands succeeded
  py36-dj22: commands succeeded
  py37-dj20: commands succeeded
  py37-dj21: commands succeeded
  py37-dj22: commands succeeded
  pypy3-dj20: commands succeeded
  pypy3-dj21: commands succeeded
  pypy3-dj22: commands succeeded
  congratulations :)

miki725
miki725 commented Jun 24, 2019
View reviewed changes
tox.ini Outdated
@@ -1,15 +1,41 @@
[tox]
skipsdist = true
envlist = py27,py36
envlist =
{py27,py36,pypy}-{dj11}
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

want to add diff drf versions? remember something changed in serializers a while back so maybe testing multiple versions will help. thoughts?

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

3.8 and 3.9 should do

shosca
shosca reviewed Jun 24, 2019
View reviewed changes
Copy link
Owner

@shosca shosca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

miki725
miki725 commented Jun 24, 2019
View reviewed changes
tox.ini
dj21: django<2.2
dj22: django<2.3
drf38: djangorestframework<3.9
drf39: djangorestframework<3.10,<4
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dont know for sure what new version will be called either 3.10 or 4.0 so accounting for both.

although given that drastic new features are unlikely probably will be 3.10 but uncertain especially with all the asgi advancement and openapi proliferation.

@shosca shosca merged commit 648e66b into master Jun 24, 2019
@shosca shosca deleted the tox-matrix branch June 24, 2019 02:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shosca shosca shosca approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@miki725 @shosca