37717 unicode support #54
Conversation
sgsteph
commented
Aug 4, 2016
sgsteph
commented
- Qt emits strings as unicode, so all Slots now expect unicode values instead of strings and convert them encoded utf-8 strings before using them.
- Fixed Shot name editing regexp so it works with unicode.
- Added an example EDL with lot of unicode. Please note that importing this EDL file will fail when trying to upload it in SG because of the special characters in the file name.
- Fixed group matching for note addressing so group names can contain unicode characters.
Changed all str slots to unicode slots, as this is what is send by Qt. Convert unicode strings to utf-8 encoded strings before using them. Fixed shot name validator so it works with unicode strings.
|
Looks good, Stéphane! My main comment is the new uvariable names are a little hard to read. Maybe switch it to vars like: u_path ... instead of: upath Besides that, I wanted to make sure you checked the Omit statuses. I.e., if unicode characters are set as sg_status_list statuses on Shots, will they play nice with our pull-down menus? (It looks like you did some work to make sure the notification Groups work). |
|
Python hungarian notation lol! >.< @thebeeland mentioned today that by emitting strings as objects instead of as strings, their stringiness is preserved. Maybe something to try? |
|
@manneohrstrom I think that emitting strings as objects would imply keeping a reference to them around ? By using regular |
Renamed uxxxx variables to u_xxxx and avoid re-using slot params to store converted string, but rather use an additional variable. Convert all strings retrieved from widgets to utf-8 encoded strings. More fixes for group editing in settings dialog which was previously missed.
|
Looks good, no comments, merge at will. |
Merge branch '37717_unicode_support'
