Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimise Redis cache loop #450

Merged
merged 1 commit into from
Jan 14, 2022
Merged

Optimise Redis cache loop #450

merged 1 commit into from
Jan 14, 2022

Conversation

conorbros
Copy link
Member

@conorbros conorbros commented Jan 13, 2022 •
edited
Loading

Something I noticed while investigating #448. We can early return from this loop the first time we notice a QueryType::Write and not scan through the rest of the messages, and I added a comment to make the logic a little clearer.

rukai
rukai approved these changes Jan 14, 2022
View reviewed changes
Copy link
Member

@rukai rukai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I cant imagine what the purpose of a count over a simple bool would have been

@conorbros conorbros enabled auto-merge (squash) January 14, 2022 00:35
@conorbros conorbros merged commit 2da414b into shotover:main Jan 14, 2022
@conorbros conorbros deleted the fix-cache-loop branch January 14, 2022 02:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rukai rukai rukai approved these changes

@benbromhead benbromhead benbromhead approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@conorbros @rukai @benbromhead