Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename message::Value #482

Merged
merged 1 commit into from
Jan 28, 2022
Merged

Rename message::Value #482

merged 1 commit into from
Jan 28, 2022

Conversation

rukai
Copy link
Member

@rukai rukai commented Jan 27, 2022

I chose ShotoverValue but maybe something like GenericValue or MessageValue could work?

Copy link
Member

@conorbros conorbros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I prefer MessageValue because I imagine a transform developer interacting with Message and MessageValue better than Message and ShotoverValue but isn't a big deal so LGTM.

@rukai
Copy link
Member Author

rukai commented Jan 27, 2022

Yeah, after thinking about it, I agree, MessageValue does sound better.
ill swap to that.

@rukai rukai force-pushed the shotover_value branch 2 times, most recently from c27b9fb to 838e005 Compare January 27, 2022 09:20
Copy link
Member

@benbromhead benbromhead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm ok with MessageValue, but something like DatastoreValue is more descriptive (e.g. it is a value from the datastore)

@rukai
Copy link
Member Author

rukai commented Jan 28, 2022

It is currently used in cases the value didnt come from a datastore, so atm MessageValue makes more sense.
Although we might want to remove those cases in the future and then DatastoreValue would end up a better name.

@rukai rukai merged commit e665309 into shotover:main Jan 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants