Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change timeout in TcpCodecListener #644

Merged
merged 6 commits into from
May 19, 2022
Merged

Conversation

conorbros
Copy link
Member

Change the timeout in TcpCodecListener to more closely replicate the behaviour of the source that's representing.

  • Redis by default has no timeout but the user can configure one.
  • Cassandra by default has no timeout either but the user can configure one.

@conorbros conorbros requested a review from rukai May 13, 2022 07:46
docs/src/source-types.md Outdated Show resolved Hide resolved
shotover-proxy/src/server.rs Outdated Show resolved Hide resolved
Copy link
Member

@rukai rukai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Member

@benbromhead benbromhead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@conorbros conorbros merged commit c912a2d into shotover:main May 19, 2022
@conorbros conorbros deleted the source-timeout branch May 19, 2022 01:59
@rukai rukai mentioned this pull request Dec 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants