cassandra_int_tests: add test_node_going_down #858
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
conorbros
approved these changes
Oct 14, 2022
rukai
force-pushed
the
node_going_down_int_tests
branch
from
0e038c3
to
78942be
Compare
benbromhead
approved these changes
Oct 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
test_events_filtering is renamed to test_node_going_down and extended to test that shotover can continue to process incoming messages after a node goes down.
Currently this only tests connections created after a node goes down as that is all that shotover currently handles.
But I have added TODO's to test connections created before a node goes down for once shotover does handle that.
I also made the event assertions more robust by handling the
StatusChangeType::Upevent that can occur by reordering the test cases.