Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix prepared results bug #945

Merged
merged 2 commits into from Dec 7, 2022
Merged

fix prepared results bug #945

merged 2 commits into from Dec 7, 2022

Conversation

conorbros
Copy link
Member

The entire frame was being compared to check if all the prepared responses were the same and having the tracing flag set meant that all frames had different tracing ids. This PR only checks that the prepared metadata part of the response is used for comparison.

Copy link
Member

@rukai rukai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@rukai rukai linked an issue Nov 29, 2022 that may be closed by this pull request
@rukai rukai enabled auto-merge (squash) December 7, 2022 23:21
@rukai rukai merged commit d0a4e7b into shotover:main Dec 7, 2022
@conorbros conorbros deleted the prepared-bug-fix branch December 8, 2022 01:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cluster_single_rack_v4::case_1_cdrs has many tracing errors
3 participants