Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix prepared results bug #945

Merged
merged 2 commits into from
Dec 7, 2022
Merged

fix prepared results bug #945

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6df4476
fix prepared results bug
conorbros Nov 29, 2022
df9132d
Merge branch 'main' into prepared-bug-fix
rukai Dec 7, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
45 changes: 23 additions & 22 deletions shotover-proxy/src/transforms/cassandra/sink_cluster/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ use async_trait::async_trait;
use cassandra_protocol::events::ServerEvent;
use cassandra_protocol::frame::message_error::{ErrorBody, ErrorType, UnpreparedError};
use cassandra_protocol::frame::message_execute::BodyReqExecuteOwned;
use cassandra_protocol::frame::message_result::BodyResResultPrepared;
use cassandra_protocol::frame::message_result::PreparedMetadata;
use cassandra_protocol::frame::{Opcode, Version};
use cassandra_protocol::query::QueryParams;
Expand Down Expand Up @@ -487,30 +488,30 @@ impl CassandraSinkCluster {
)
.await?;

if !prepare_responses.windows(2).all(|w| w[0] == w[1]) {
let err_str = prepare_responses
.iter_mut()
.filter_map(|response| {
if let Some(Frame::Cassandra(CassandraFrame {
operation:
CassandraOperation::Result(CassandraResult::Prepared(prepared)),
..
})) = response.frame()
{
Some(format!("\n{:?}", prepared))
} else {
None
}
})
let prepared_results: Vec<&mut Box<BodyResResultPrepared>> = prepare_responses
.iter_mut()
.filter_map(|message| {
if let Some(Frame::Cassandra(CassandraFrame {
operation: CassandraOperation::Result(CassandraResult::Prepared(prepared)),
..
})) = message.frame()
{
Some(prepared)
} else {
None
}
})
.collect();

if !prepared_results.windows(2).all(|w| w[0] == w[1]) {
let err_str = prepared_results
.iter()
.map(|p| format!("\n{:?}", p))
.collect::<String>();

if cfg!(test) {
panic!("{}", err_str);
} else {
tracing::error!(
"Nodes did not return the same response to PREPARE statement {err_str}"
);
}
tracing::error!(
"Nodes did not return the same response to PREPARE statement {err_str}"
);
}
}

Expand Down