Feature/seext 9440 retry downloading extensions if download fails during shoutem clone #109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
majaklajic
suggested changes
Mar 5, 2021
src/commands/clone.js
Outdated
| } | ||
| } | ||
|
|
||
| if (!_.isEmpty(pullError)) { |
majaklajic
previously approved these changes
Mar 5, 2021
Definitely-Not-Vlad
dismissed stale reviews from sstimac and majaklajic
via
0650ed1
Definitely-Not-Vlad
deleted the
feature/SEEXT-9440-Retry_downloading_extensions_if_download_fails_during_shoutem_clone
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR would implement a simple loop that tries to download an exension up to 5 times before reporting an error.
This should improve the consistency of downloading extensions on less stable network connections.
Can be tried with
npm i -g shoutem/cli#76300a1, or whatever the latest commit's short-hash.