Replace Grunt with Gulp #119
Conversation
| @@ -1,5 +1,6 @@ | |||
| .DS_Store | |||
| /node_modules | |||
| /npm-debug.log* | |||
There was a problem hiding this comment.
npm-debug.log sometimes gets appended with timestamp. * handles that.
| 'lib/*/*.js', | ||
|
|
||
| // Plugins. | ||
| 'node_modules/shower-*/shower-*.js', |
There was a problem hiding this comment.
I hope you don't mind trailing commas, do you?
They make diffs so much better.
There was a problem hiding this comment.
Anything except leading commas is fine ;)
| .pipe(git.add()) | ||
| .pipe(git.commit('Bump version number')); | ||
| .on('end', () => { | ||
| git.push('origin', 'master', error => { |
There was a problem hiding this comment.
Another way is to include gulp-git-push, more on this.
| @@ -21,8 +21,6 @@ | |||
| <div class="progress"></div> | |||
| </div> | |||
|
|
|||
| <script src="../bind.polyfill.js"></script> | |||
There was a problem hiding this comment.
Polyfill itself was removed in f065286.
| .pipe(bump()) | ||
| .pipe(gulp.dest('.')) | ||
| .pipe(git.add()) | ||
| .pipe(git.commit('Bump version number')) |
There was a problem hiding this comment.
Commit message changed from Release v${newVersion}. Otherwise it will be quite awkward to implement. Please tell me if this is acceptable.
There was a problem hiding this comment.
You can drop bump task altogether, I’m releasing with np these days anyway.
There was a problem hiding this comment.
Removed in 4fcabed. -2 deps, yay!
|
LGTM |
Because
Gulpfile.jsis written in ES6, Node.js 4+ is required to runGulp.