Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slides cannot touch right-hand edge #48

Closed
wants to merge 1 commit into from
Closed

Slides cannot touch right-hand edge #48

wants to merge 1 commit into from

Conversation

RubenVerborgh
Copy link
Contributor

The current list view does not enforce a minimum right-hand edge, leading to an unbalanced view in certain widths.

Current list view: no minimum margin at right-hand edge

image

Updated list view: minimum margin at right-hand edge

image

@pepelsbey
Copy link
Contributor

While it’s technically accurate to have the same paddings on both sides (it used to be like that initially), the lack of padding on the right side gives a room for slides in –0.5 scale not to switch to –0.25 too soon, but only when there’s not enough space for actual slides, not their margins.

And since I did it intentionally to keep slides in list mode as big as possible, I’m still not conviced to revert this behaviour only for sake of accuracy.

There’s a next themes generation I currently develop that could solve this problem partially. It’s based on custom CSS properties and calc() instead of Sass math, so they dynamically calculate scaling without bloating CSS with too many pre-generated variations. So once we have more scaling fractions we could keep accurate paddings around them.

@RubenVerborgh
Copy link
Contributor Author

Hah, interesting, because I found this bug actually while looking into the switching problem with calc 😄
I'll wait then and leave it up to you.

Where's the next gen being developed?

@pepelsbey
Copy link
Contributor

It’s still being developed locally, but there’s going to be a separate “blank” repository soon, sort of template for a new theme.

@RubenVerborgh RubenVerborgh deleted the fix-list-right-margin branch December 29, 2016 23:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants