Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No arguments will give help information #272

Merged
merged 7 commits into from
Jan 30, 2023
Merged

No arguments will give help information #272

merged 7 commits into from
Jan 30, 2023

Conversation

arm61
Copy link
Contributor

@arm61 arm61 commented Jan 30, 2023

I have chosen to stick with the entry_point approach, removing this raises some issues with the tests failing that are beyond my current understanding of how showyourwork operates.

@dfm
Copy link
Member

dfm commented Jan 30, 2023

I actually think the approach in #271 was better because I'd prefer to depend on click's handling of the logic rather than re-implementing it ourselves. The test errors were appearing only because of a missing import - easily fixable! How would you feel about re-opening that one and giving it another shot?

@arm61
Copy link
Contributor Author

arm61 commented Jan 30, 2023

Can do!

@arm61
Copy link
Contributor Author

arm61 commented Jan 30, 2023

Okay, it looks like that works now. Thoughts?

@dfm dfm added the safe to test Used by maintainers to run expensive remote tests on PRs label Jan 30, 2023
@github-actions github-actions bot removed the safe to test Used by maintainers to run expensive remote tests on PRs label Jan 30, 2023
@dfm
Copy link
Member

dfm commented Jan 30, 2023

I don't know what was up with the pre-commit check, but looks like we've got it working now!

So simplify the diff, I renamed __init__.py back to main.py then imported main as entry_point in __init__. It's really just a matter of taste, but I prefer to have as little as possible in the __init__. Otherwise I think this is good to go as soon as we get all green on the tests! Thank you 🚀

My plan is to merge this into the main branch, and we'll use the main branch to target v0.5. I've created a v0.4.x branch to track minor releases on the v0.4 trajectory.

@dfm dfm merged commit 6ed4c88 into showyourwork:main Jan 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants