Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ionic view lifecycle event fired inaccurately #23

Closed
NgYueHong opened this issue Nov 2, 2015 · 7 comments
Closed

Ionic view lifecycle event fired inaccurately #23

NgYueHong opened this issue Nov 2, 2015 · 7 comments
Milestone

Comments

@NgYueHong
Copy link

When Ionic page transition animation is disabled via $ionicConfigProvider.views.transition('none'), the view event like $ionicView.afterEnter will not executes accurately. You can clearly see the problem when you test on low end budget device. This brings the problem of same page being animate in, even if you try to animate it with afterLeave.

I have report the issue to ionic (ionic-team/ionic-framework#4555), but I don't hope to see any action taken for it soon. So, for now the only way is to avoid disable animation using $ionicConfigProvider.views.transition('none'). The downside is we will have a small delay on page transition that we need to wait for ionic animation to finish, only then animate ours. Or you have any idea of alternative way to disable ionic animation or speed up the animation to make it extreme fast like almost no transition?

@NgYueHong
Copy link
Author

I found that we can have accurate ionic view event with no animation by using nav-transition="none". Please see how this can be implemented into your plugin. Thank you.

@shprink
Copy link
Owner

shprink commented Nov 2, 2015

Thanks for the research. I will check if I can add this directive during
config time.
On 2 Nov 2015 01:04, "NgYueHong" notifications@github.com wrote:

I found that we can have accurate ionic view event with no animation by
using nav-transition="none". Please see how this can be implemented into
your plugin. Thank you.


Reply to this email directly or view it on GitHub
#23 (comment)
.

@shprink
Copy link
Owner

shprink commented Nov 7, 2015

Do you mean this: http://ionicframework.com/docs/api/directive/navTransition/ ?

If so I do not think this plugin can do anything about it except adding this to the documentation. What do you think?

@NgYueHong
Copy link
Author

@shprink Yeah, I am referring to that. If that can't be done, then adding to the documentation would be fine. However, I guess you may need to remove $ionicConfig.views.transition('none') from your code. Otherwise, people will need to manually remove it from your code or add $ionicConfig.views.transition('platform') on their code to override yours to avoid the problem.

@shprink
Copy link
Owner

shprink commented Nov 8, 2015

You can now disable/enable ionic transitions using:

https://github.com/shprink/ionic-native-transitions/blob/develop/README.md#enabledisable-optional

@NgYueHong
Copy link
Author

@shprink That's awesome!!!! Didn't notice it is implemented.

@shprink
Copy link
Owner

shprink commented Nov 8, 2015

I am listening to you bro :)

@shprink shprink closed this as completed Nov 19, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants