Skip to content

Commit

Permalink
Browse files Browse the repository at this point in the history
97402: bench: skip a failing case in BenchmarkFuncExprTypeCheck r=yuzefovich a=yuzefovich

Informs: cockroachdb#97400.

Release note: None

Co-authored-by: Yahor Yuzefovich <yahor@cockroachlabs.com>
  • Loading branch information
craig[bot] and yuzefovich committed Feb 21, 2023
2 parents 4806560 + 260a66c commit 2036af6
Showing 1 changed file with 7 additions and 5 deletions.
12 changes: 7 additions & 5 deletions pkg/bench/bench_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -1443,7 +1443,8 @@ func BenchmarkFuncExprTypeCheck(b *testing.B) {
sqlDB.ExecMultiple(b,
`CREATE SCHEMA sc1`,
`CREATE SCHEMA sc2`,
`CREATE FUNCTION abs(val INT) RETURNS INT CALLED ON NULL INPUT LANGUAGE SQL AS $$ SELECT val $$`,
// TODO(chengxiong): uncomment this when #97400 is resolved.
//`CREATE FUNCTION abs(val INT) RETURNS INT CALLED ON NULL INPUT LANGUAGE SQL AS $$ SELECT val $$`,
`CREATE FUNCTION sc1.udf(val INT) RETURNS INT CALLED ON NULL INPUT LANGUAGE SQL AS $$ SELECT val $$`,
`CREATE FUNCTION sc1.udf(val STRING) RETURNS STRING LANGUAGE SQL AS $$ SELECT val $$`,
`CREATE FUNCTION sc1.udf(val FLOAT) RETURNS FLOAT LANGUAGE SQL AS $$ SELECT val $$`,
Expand Down Expand Up @@ -1487,10 +1488,11 @@ func BenchmarkFuncExprTypeCheck(b *testing.B) {
name: "builtin aggregate not called on null",
exprStr: "concat_agg(NULL)",
},
{
name: "udf same name as builtin",
exprStr: "abs(123)",
},
// TODO(chengxiong): uncomment this when #97400 is resolved.
//{
// name: "udf same name as builtin",
// exprStr: "abs(123)",
//},
{
name: "udf across different schemas",
exprStr: "udf(123)",
Expand Down

0 comments on commit 2036af6

Please sign in to comment.