NPE when reading version.properties

[marsangr]

The following code in HttpConnector from the draft branch

    try (InputStream in = HttpConnector.class.getResourceAsStream("/org/shredzone/acme4j/version.properties")) {
        Properties prop = new Properties();
        prop.load(in);
        agent.append('/').append(prop.getProperty("version"));
    } catch (IOException ex) {
        // Ignore, just don't use a version
        LoggerFactory.getLogger(HttpConnector.class).warn("Could not read library version", ex);
    }

throws a NullPointerException in the load() method when running against a freshly checked out version.properties.

Since reading the version seems not to be critical, I'd rather change the catch(IOException) to a more generic catch(Exception).

[shred]

I agree. I'm going to fix that.

[shred]

Fixed in master and draft branch. The release jars are not affected by this issue, so I'm closing it. Thank you!