Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jupyter is an (undeclared) build-time dependency #440

Closed
QuLogic opened this issue Jan 30, 2024 · 6 comments
Closed

jupyter is an (undeclared) build-time dependency #440

QuLogic opened this issue Jan 30, 2024 · 6 comments

Comments

@QuLogic
Copy link
Member

QuLogic commented Jan 30, 2024

The chain unconditionally goes meson.build -> examples/meson.build -> examples/notebooks/meson.build, and in the last file is a call to find_program('jupyter'). But this defaults to required:true, meaning that that program is required to build. However, it is not listed in the build-system.requires entry in pyproject.toml. It also isn't in the runtime dependencies or, e.g., a "test" optional dependency list.

If you're building a normal (non-editable) install, then build isolation is enabled, but it won't affect $PATH, so this probably snuck by. But if you're building in a completely clean environment (cibuildwheel, distro packages, etc.) that just install what's in the metadata, it will fail.

@vianamp
Copy link

vianamp commented Mar 14, 2024

I confirm this problem.

@MarkWieczorek
Copy link
Member

This is fixed in the develop branch, and I'll be merging this to master next week.

@vianamp
Copy link

vianamp commented Mar 14, 2024

Thank you. Also, not related but, can you please tell me if you ever tried to install pyshtools using Python 3.11?

@MarkWieczorek
Copy link
Member

Are you having a problem with 3.11? It should work.

@vianamp
Copy link

vianamp commented Mar 15, 2024

Yes, I can only get pyshtools installed in 3.11 if I pin the version to 4.10.4. I am running ubuntu 18.04.

@MarkWieczorek
Copy link
Member

Could you please open a separate issue, and provide all the necessary details to reproduce and debug this problem? Please also be aware that there are several issues open regarding 4.11 because there is no wheel or conda package available at this time. At this point, installing via pip will install from source, and you will need to install the necessary dependencies.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants