Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add timeout and cancellation token support #43

Closed
yoricksmeets opened this issue Apr 3, 2020 · 2 comments
Closed

Add timeout and cancellation token support #43

yoricksmeets opened this issue Apr 3, 2020 · 2 comments
Assignees
@yoricksmeets
Labels
enhancement New feature or request

Comments

@yoricksmeets
Copy link
Contributor

Hi, first of all thank you for this library!

I'm building a simple proof of concept project that can do distributed locking using etcd using the 'lockClient' part of the EtcdClient. In this PoC would like to pass a timeout while aquiring a lock, but the deadline and/or cancellationtoken of the gRPC client are not part of the public API of the client. Therefor there is no nice way to implement the timeout. I would like to add both fields to the public API so I can implement this timeout.
yoricksmeets added a commit to yoricksmeets/dotnet-etcd that referenced this issue Apr 3, 2020
@yoricksmeets
shubhamranjan#43 - Expose deadline and cancellationToken in public AP…
386143a 
…I and provide this input to the gRPC client method
@yoricksmeets yoricksmeets mentioned this issue Apr 3, 2020
Merged
yoricksmeets added a commit to yoricksmeets/dotnet-etcd that referenced this issue Apr 4, 2020
@yoricksmeets
shubhamranjan#43 - Expose deadline and cancellationToken in public AP…
152e688 
…I and provide this input to the gRPC client method
shubhamranjan pushed a commit that referenced this issue Apr 4, 2020
@yoricksmeets @shubhamranjan
#43 - Expose deadline and cancellationToken in public API and provide…
af34314 
… this input to the gRPC client method
@shubhamranjan shubhamranjan changed the title Add 'timeout' when waiting for lock Add timeout and cancellation token support Apr 4, 2020
@yoricksmeets
Copy link
Contributor Author

I'm adding this change to the other parts of the client as well at the moment. I'm also updating missing documentation on methods when I touch them.

@shubhamranjan
Copy link
Owner

Cool. Thanks. I will wait for the changes then and release all together.

@shubhamranjan shubhamranjan added the enhancement New feature or request label Apr 5, 2020
yoricksmeets added a commit to yoricksmeets/dotnet-etcd that referenced this issue Apr 6, 2020
@yoricksmeets
shubhamranjan#43 Add timeout and cancellation token support to authCl…
2d42ff2 
…ient, clusterClient, kvClient, leaseClient, lockClient, maintenanceClient, watchClient
yoricksmeets added a commit to yoricksmeets/dotnet-etcd that referenced this issue Apr 6, 2020
@yoricksmeets
shubhamranjan#43 Add timeout and cancellation token support to authCl…
1843553 
…ient, clusterClient, kvClient, leaseClient, lockClient, maintenanceClient, watchClient
yoricksmeets added a commit to yoricksmeets/dotnet-etcd that referenced this issue Apr 6, 2020
@yoricksmeets
shubhamranjan#43 Add timeout and cancellation token support to authCl…
4e68b93 
…ient, clusterClient, kvClient, leaseClient, lockClient, maintenanceClient, watchClient
yoricksmeets added a commit to yoricksmeets/dotnet-etcd that referenced this issue Apr 6, 2020
@yoricksmeets
shubhamranjan#43 Add timeout and cancellation token support to authCl…
d944a79 
…ient, clusterClient, kvClient, leaseClient, lockClient, maintenanceClient, watchClient
@yoricksmeets yoricksmeets mentioned this issue Apr 6, 2020
Merged
shubhamranjan pushed a commit that referenced this issue Apr 6, 2020
@yoricksmeets @shubhamranjan
#43 Add timeout and cancellation token support to authClient, cluster…
b0145e1 
…Client, kvClient, leaseClient, lockClient, maintenanceClient, watchClient
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yoricksmeets yoricksmeets

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@yoricksmeets @shubhamranjan