Updated Validate.record_hostname() to support second level names

shupp · Apr 21, 2015 · fd3f179 · fd3f179
1 parent b6b39a3
commit fd3f179
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/tests/test_validate.py b/tests/test_validate.py
@@ -32,6 +32,7 @@ def test_ipv6_invalid(self):
         self.assertFalse(Validate.ipv6('i like turtles'))
 
     def test_record_name_valid(self):
+        self.assertTrue(Validate.record_hostname('vegadns.org'))
         self.assertTrue(Validate.record_hostname('www.vegadns.org'))
         self.assertTrue(Validate.record_hostname('foo.www.vegadns.org'))
         self.assertTrue(Validate.record_hostname('bar.foo.www.vegadns.org'))

diff --git a/vegadns/validate/records.py b/vegadns/validate/records.py
@@ -22,12 +22,12 @@ def ipv6(ipv6_address):
 
     @staticmethod
     def record_hostname(hostname):
-        # All record hostnames must be at least a third level
-        if hostname.count('.') <= 1:
+        # All record hostnames must be at least a second level
+        if hostname.count('.') < 1:
             return False
 
         # Currently only allowing a-z,0-9,- etc per old app
-        # May want to revisit this for non-alphanumeric support
+        # This needs revisiting to be RFC compliant
         p = re.compile(
             '^([\*a-z0-9-\/]+[\.])+[a-z0-9-]+[\.]{0,1}$',
             re.IGNORECASE