Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

goe programs will potentially use outdated packages. #3

Closed
dmitshur opened this issue Jan 5, 2014 · 1 comment · Fixed by #5
Closed

goe programs will potentially use outdated packages. #3

dmitshur opened this issue Jan 5, 2014 · 1 comment · Fixed by #5
Labels
bug

Comments

@dmitshur
Copy link
Member

dmitshur commented Jan 5, 2014

Since the generated .go file resides somewhere in a temporary folder, it is outside the GOPATH boundary, and if a package is built but outdated (i.e. source code has been changed since it was built), the outdated version will be used.
@ghost ghost assigned dmitshur Jan 5, 2014
@dmitshur dmitshur mentioned this issue Jan 6, 2014
Closed
dmitshur added a commit that referenced this issue Apr 25, 2014
@dmitshur
Temporary inefficient solution for #3.
95bb2b3 
This causes it to recompile all packages at all times, solving the
problem of potentially using stale packages in a very inefficient
manner. The correct solution is for go command to be improved upstream.
@dmitshur
Copy link
Member Author

dmitshur commented Jun 4, 2015

golang/go#10509 has been resolved! As soon as 1.5 is out, I can resolve this issue.

@dmitshur dmitshur mentioned this issue Aug 7, 2015
Merged
dmitshur added a commit that referenced this issue Aug 7, 2015
@dmitshur
Revert temporary solution to avoid stale builds, unneeded in Go 1.5.
be8fb0b 
This change depends on Go 1.5 being used.

In Go 1.5, a longstanding issue golang/go#10509 has been finally resolved!

Since the generated .go file resides somewhere in a temporary folder, it was
outside the GOPATH boundary, and if a package is built but stale (i.e. source
code has been changed since it was built), the stale version would've been used.

This reverts a temporary inefficient solution (95bb2b3)
of rebuilding absolutely all packages at all times just to avoid the risk of
incorrectly building with a stale package.

Resolves #3.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Revert temporary solution to avoid stale builds, unneeded in Go 1.5. shurcooL/goexec
1 participant
@dmitshur