Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert temporary solution to avoid stale builds, unneeded in Go 1.5. #5

Merged
merged 1 commit into from
Aug 20, 2015

Conversation

dmitshur
Copy link
Member

@dmitshur dmitshur commented Aug 7, 2015

This change depends on Go 1.5 being used, and should be merged after Go 1.5 is released.

In Go 1.5, a longstanding issue golang/go#10509 has been finally resolved!

Since the generated .go file resides somewhere in a temporary folder, it was outside the GOPATH boundary, and if a package is built but stale (i.e. source code has been changed since it was built), the stale version would've been used.

This reverts a temporary inefficient solution (95bb2b3) of rebuilding absolutely all packages at all times just to avoid the risk of incorrectly building with a stale package.

Resolves #3.

This change depends on Go 1.5 being used.

In Go 1.5, a longstanding issue golang/go#10509 has been finally resolved!

Since the generated .go file resides somewhere in a temporary folder, it was
outside the GOPATH boundary, and if a package is built but stale (i.e. source
code has been changed since it was built), the stale version would've been used.

This reverts a temporary inefficient solution (95bb2b3)
of rebuilding absolutely all packages at all times just to avoid the risk of
incorrectly building with a stale package.

Resolves #3.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

goe programs will potentially use outdated packages.
1 participant