Revert temporary solution to avoid stale builds, unneeded in Go 1.5. #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change depends on Go 1.5 being used. In Go 1.5, a longstanding issue golang/go#10509 has been finally resolved! Since the generated .go file resides somewhere in a temporary folder, it was outside the GOPATH boundary, and if a package is built but stale (i.e. source code has been changed since it was built), the stale version would've been used. This reverts a temporary inefficient solution (95bb2b3) of rebuilding absolutely all packages at all times just to avoid the risk of incorrectly building with a stale package. Resolves #3.
dmitshur
force-pushed
the
fix-outdated-for-go1.5
branch
from
3891c89
to
be8fb0b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change depends on Go 1.5 being used, and should be merged after Go 1.5 is released.
In Go 1.5, a longstanding issue golang/go#10509 has been finally resolved!
Since the generated .go file resides somewhere in a temporary folder, it was outside the GOPATH boundary, and if a package is built but stale (i.e. source code has been changed since it was built), the stale version would've been used.
This reverts a temporary inefficient solution (95bb2b3) of rebuilding absolutely all packages at all times just to avoid the risk of incorrectly building with a stale package.
Resolves #3.