Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

renderer: Fenced Code Block info string should not trim to first word only. #58

Closed
bwplotka opened this issue Oct 27, 2020 · 2 comments
Closed

Comments

@bwplotka
Copy link

It's totally allowed by markdown language to have longer info string that is not limited to a single word. I would love to leverage that in my tool, during formatting, but I can't as markdownfmt trims all to a single word.

Would you accept a PR that would leave the info string unchanged?

bwplotka added a commit to bwplotka/markdownfmt that referenced this issue Oct 27, 2020
Related issue: shurcooL#58

Signed-off-by: Bartlomiej Plotka <bwplotka@gmail.com>
bwplotka added a commit to bwplotka/markdownfmt that referenced this issue Oct 27, 2020
Related issue: shurcooL#58

Signed-off-by: Bartlomiej Plotka <bwplotka@gmail.com>
@dmitshur
Copy link
Member

That sounds like a bug, fixing which is in scope. I have little bandwidth to do code review or fix bugs in this project, so it's hard to promise anything.

In general, I'd recommend picking a more active fork to contribute to instead. This issue may even get fixed if using blackfriday v2 (#39) or goldmark (#56).

leave the info string unchanged

It should still trim the whitespace at the both ends.

@bwplotka
Copy link
Author

bwplotka commented Oct 28, 2020

It should still trim the whitespace at the both ends.

agree.

Thanks!

I did that here: Kunde21/markdownfmt#12

Happy to close it then.

bwplotka added a commit to bwplotka/markdownfmt that referenced this issue Oct 28, 2020
Related issue: shurcooL#58

Signed-off-by: Bartlomiej Plotka <bwplotka@gmail.com>
Kunde21 pushed a commit to Kunde21/markdownfmt that referenced this issue Oct 28, 2020
Related issue: shurcooL/markdownfmt#58

Signed-off-by: Bartlomiej Plotka <bwplotka@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants