-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
initdb commands for decryptor and keyper #23
Conversation
Return all tables except for the ones postgres creates by default.
So, you're calling the linter a liar? That's mean. It just asks you to change the code to:
|
668e7f2
to
dde6390
Compare
You're right, I sincerely apologize to the linter. |
Why do we need the empty database check? That's rather unusual I'd say. Maybe 'CREATE TABLE IF NOT EXISTS..` |
I just want to check that the db isn't already initialized and that it's not used for anything else. The former could be done with |
yes, that's not necessary. You might have a look at https://github.com/golang-migrate/migrate, which is what we may end up using to manage database migrations (though that's also not necessary at the moment). |
dde6390
to
30e9bb1
Compare
…t-db initdb commands for decryptor and keyper
Closes #14 and #17
The linter doesn't like it, but I think it is wrong: Rows.Close doesn't return an error. It might be confused because Rows.Close from the database/sql package does.