Allow series to contain an empty array of data #223
Conversation
Rickshaw assumes that there is a datum at index [0] and index [length-1] for all series. This patch corrects that assumption to allow for empty data sets.
|
Why was this closed? I would have loved to see this change make it in :( |
|
hey @drock, made this pull to the wrong repository, rookie mistake -.- I'd be happy to reopen it, minus the build, if you though it would be useful. It's more hack null-value-checks than anything else |
|
I would personally like it. I have a project where I create my graphs first and then wait for data to arrive via Ajax before adding the series and drawing the chart. As it stands right now I have to add a dummy series and then remove it when the real data comes in. |
|
@will-ob Was this ever reopened as a new pull request? I can't find a similar commit/request made to fix the issue. |
|
@bayan - i had not opened a pr, the commit was more of a hack than a fix. 'Failing gracefully' was not a requirement for us. Not a bad jumping off point though. This is the commit: |
|
@will-ob anyone pick this up again, failing gracefully would be nice |
|
I have similar situation, ajax data returned from remote server might be empty. |
As is, rickshaw assumes the existence of
data[0]anddata[length-1]. This patch corrects that.