Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent selecting no data with RangeSlider #406

Closed

Conversation

glasnt
Copy link
Contributor

@glasnt glasnt commented Mar 6, 2014

In addition to preventing the range slider from overlapping, make it so that it always has at least one point of data displayed. Otherwise, all data from graph could disappear.

Only uses the step from the first series on the graph though. Unsure how prudent it would be to get the largest (or smallest) step for all series to use as the limit.

…so that it always has at least one point of data displayed. Otherwise, all data from graph could disappear.
@dchester
Copy link
Contributor

dchester commented Mar 7, 2014

This would be a nice feature to have, but I think this implementation makes too many assumptions -- that the first data series has evenly spaced points; and that the first series has the same granularity as the rest (as you pointed out). There's a possible worst case scenario I'd like to avoid here, where the spacing of the first two points is such that productive zooming on other parts of the graph would be disabled.

@glasnt
Copy link
Contributor Author

glasnt commented Mar 24, 2014

Fair call. I worked this out in my own implementation of this change as well.
Perhaps if there was a way to check if there would be no points being displayed per the filter before it was implemented, but that might be too difficult to implement.

@glasnt glasnt closed this Mar 24, 2014
@glasnt glasnt deleted the limited_slider branch March 24, 2014 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants