Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Improvement]: Consider if migrating to tower-sessions is appropriate #1288

Closed
1 task done
maxcountryman opened this issue Oct 2, 2023 · 2 comments
Closed
1 task done
Labels
S-Triage Awaiting decision for what to do T-Improvement Improvement or addition to existing features

Comments

@maxcountryman
Copy link

Describe the improvement

Hi folks,

I'm the author of axum-sessions, which is a crate I see you all are using--I'm glad to see you've found it useful!

Over the course of the last year or so we've hit some roadblocks with our key dependency, async-session. The long and short of that is in order to unblock that and address some problems with axum-sessions's design, we've released a new crate which aims to replace axum-sessions: tower-sessions.

tower-sessions no longer relies on a third-party crate for its session implementation and this has allowed us to change its design to better fit tower and the broader tower ecosystem (i.e. axum). For instance, we no longer need writable and readable sessions, and have simplified the interface as a result.

I'd be curious if there's interest in migrating and am happy to help if so.

Duplicate declaration

  • I have searched the issues and this improvement has not been requested before.
@maxcountryman maxcountryman added S-Triage Awaiting decision for what to do T-Improvement Improvement or addition to existing features labels Oct 2, 2023
@oddgrd
Copy link
Contributor

oddgrd commented Oct 4, 2023

Hey @maxcountryman, thanks for opening this issue and for offering to help in implementing this change. I think the new crate looks good, and I think it's great that you designed it around tower! The reason we didn't accept this issue yet, is that we don't currently use the sessions flow in our auth service (which is what uses axum-sessions). We might do so in the future, though, we just need to discuss this a bit internally. We'll get back to you when we have an answer. Thanks again!

@oddgrd
Copy link
Contributor

oddgrd commented Jan 31, 2024

Hello again @maxcountryman! We have decided to fully remove our sessions code from the backend, so we will close this ticket for now. If we start using sessions on the backend again in the future, we'll consider using your crate. Thanks!

@oddgrd oddgrd closed this as completed Jan 31, 2024
@oddgrd oddgrd closed this as not planned Won't fix, can't repro, duplicate, stale Jan 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-Triage Awaiting decision for what to do T-Improvement Improvement or addition to existing features
Projects
None yet
Development

No branches or pull requests

2 participants