Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

misc: remove session #1596

Merged
merged 7 commits into from
Jan 30, 2024
Merged

misc: remove session #1596

merged 7 commits into from
Jan 30, 2024

Conversation

chesedo
Copy link
Contributor

@chesedo chesedo commented Jan 30, 2024

Description of change

Remove session management code from auth, gateway and deployer since we do not use it.

How has this been tested? (if applicable)

By running the existing tests

Copy link
Contributor

@oddgrd oddgrd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! I left some minor comments

auth/src/api/handlers.rs Outdated Show resolved Hide resolved
deployer/src/handlers/local.rs Show resolved Hide resolved
gateway/src/api/auth_layer.rs Outdated Show resolved Hide resolved
gateway/src/api/auth_layer.rs Outdated Show resolved Hide resolved
Copy link
Contributor

@oddgrd oddgrd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the cleanup!

@chesedo chesedo merged commit 4dd7971 into main Jan 30, 2024
36 checks passed
@chesedo chesedo deleted the misc/remove_session branch January 30, 2024 14:48
@jonaro00
Copy link
Member

Do we close #1288 due to this?

@oddgrd
Copy link
Contributor

oddgrd commented Jan 31, 2024

Do we close #1288 due to this?

Good point, done!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants