Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Improvement]: Check for installed Cargo in install script #1603

Closed
jonaro00 opened this issue Jan 31, 2024 · 7 comments · Fixed by #1610 or #1636
Closed

[Improvement]: Check for installed Cargo in install script #1603

jonaro00 opened this issue Jan 31, 2024 · 7 comments · Fixed by #1610 or #1636
Assignees
Labels
Contribution Wanted The community is welcome to collaborate on this issue Good First Issue Good for newcomers S-Accepted This will be worked on T-Improvement Improvement or addition to existing features

Comments

@jonaro00
Copy link
Member

jonaro00 commented Jan 31, 2024

Describe the improvement

The current install scripts, install.sh and install.ps1, currently start by trying to install a cargo-shuttle binary. Only if a binary was not downloaded do they check for if cargo is installed.

The code for checking for the cargo/rust install can be moved to the beginning of the scripts.

It is fine to solve this for just one of the scripts. Up to two people can work on this one :)


This issue is open to contribution. Comment if you want to work on it. Feel free to ask for help and guidance here or in our Discord.

@jonaro00 jonaro00 added T-Improvement Improvement or addition to existing features Good First Issue Good for newcomers Contribution Wanted The community is welcome to collaborate on this issue S-Accepted This will be worked on labels Jan 31, 2024
@Pulko
Copy link
Contributor

Pulko commented Feb 1, 2024

hey 👋 would like to try working on it

@oddgrd
Copy link
Contributor

oddgrd commented Feb 2, 2024

Thanks @Pulko!

@jonaro00
Copy link
Member Author

Solution for Linux is in progress in #1610. Contributing a solution for Powershell is still possible.

@jonaro00 jonaro00 changed the title [Improvement]: Check for installed Cargo in install scripts [Improvement]: [Powershell] Check for installed Cargo in install script Feb 22, 2024
@Pulko
Copy link
Contributor

Pulko commented Feb 22, 2024

@jonaro00 may I still take powershell script? Will create a PR after .sh is done so I would understand how the order should look like

@jonaro00
Copy link
Member Author

Yes! Thanks for the heads up.

@jonaro00 jonaro00 changed the title [Improvement]: [Powershell] Check for installed Cargo in install script [Improvement]: Check for installed Cargo in install script Feb 22, 2024
@Pulko
Copy link
Contributor

Pulko commented Feb 27, 2024

@oddgrd hey :)

that might be an automation for closing this issue that I was not aware of unfortunately

sorry for not mentioning it here, but there is one PR left to review and merge so the issue could be completed, according to the description.

@oddgrd
Copy link
Contributor

oddgrd commented Feb 27, 2024

Woops, my bad, thanks @Pulko!

@oddgrd oddgrd reopened this Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Contribution Wanted The community is welcome to collaborate on this issue Good First Issue Good for newcomers S-Accepted This will be worked on T-Improvement Improvement or addition to existing features
Projects
None yet
3 participants