Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(installer): always check for cargo install first #1610

Merged
merged 5 commits into from Feb 27, 2024

Conversation

Pulko
Copy link
Contributor

@Pulko Pulko commented Feb 2, 2024

Hey 馃憢 This is my very first contribution that I dared 馃憠馃憟

Description of change

Closes #1603

  • _install_cargo() function is checking if cargo and rustup are installed in the mid of _install_unsupported() whereas it could have been checked earlier to propose better ways of installation. I hope this would make sense and help distinguishing flows better

How has this been tested? (if applicable)

  • checked for syntax mistakes
  • ran through chat gpt lol
  • ran locally and updated cargo-shuttle

Copy link
Member

@jonaro00 jonaro00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! Looks like a good start.

install.sh Outdated Show resolved Hide resolved
install.sh Outdated Show resolved Hide resolved
install.sh Outdated Show resolved Hide resolved
install.sh Outdated Show resolved Hide resolved
@jonaro00 jonaro00 changed the title refa: refator installation script feat(installer): always check for cargo install first Feb 22, 2024
Copy link
Contributor

@oddgrd oddgrd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this @Pulko!

@oddgrd oddgrd merged commit cca27d9 into shuttle-hq:main Feb 27, 2024
36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Improvement]: Check for installed Cargo in install script
3 participants