Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: move codegen::main from service to runtime #1013

Merged
merged 1 commit into from
Jun 23, 2023
Merged

chore: move codegen::main from service to runtime #1013

merged 1 commit into from
Jun 23, 2023

Conversation

jonaro00
Copy link
Member

@jonaro00 jonaro00 commented Jun 19, 2023 •
edited
Loading

Description of change

  • Clean up the service crate by moving codegen::main to runtime (its only user). This removes the codegen feature from service, and the main function is no longer behind a feature due to being in runtime.
  • Clean up Cargo files, docs, and reorder imports/exports.

How has this been tested? (if applicable)

CI pass

@jonaro00 jonaro00 added B-Shuttle Batch Submitted by a Shuttle Batch participant B-S A small task that is a good place to start for new contributors A-service labels Jun 19, 2023
@jonaro00 jonaro00 force-pushed the chore/refactor-service-main branch from 6782abd to 13ca0ef Compare June 21, 2023 22:17
chesedo
chesedo approved these changes Jun 23, 2023
View reviewed changes
Copy link
Contributor

@chesedo chesedo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch! Thanks for the cleanup @jonaro00

@oddgrd oddgrd merged commit 9907349 into shuttle-hq:main Jun 23, 2023
29 checks passed
@jonaro00 jonaro00 deleted the chore/refactor-service-main branch June 23, 2023 15:35
@jonaro00 jonaro00 added XS and removed B-S A small task that is a good place to start for new contributors labels Jun 27, 2023
AlphaKeks pushed a commit to AlphaKeks/shuttle that referenced this pull request Jul 21, 2023
@jonaro00 @AlphaKeks
chore: move codegen::main from service to runtime (shuttle-hq#1013)
d46cefe
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chesedo chesedo chesedo approved these changes

Assignees
No one assigned
Labels
B-Shuttle Batch Submitted by a Shuttle Batch participant
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jonaro00 @chesedo @oddgrd