build(shell.nix): add openssl package to the build dependencies #1040
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oddgrd
reviewed
Jun 23, 2023
There was a problem hiding this comment.
Thanks Timon! We recently migrated to rustls across the board, but it may have been a bit optimistic, when we added cargo-generate for cargo shuttle init we got the openssl dependency back 😅
For the nix file, openssl should rather be in nativeBuildInputs, by the way
… related to missing openssl library
Thanks! Did just that 🙏 |
|
Nice! We used to only have it in |
|
No problem, oversight on my end, nice catch 💯 |
oddgrd
approved these changes
Jun 23, 2023
Kazy
pushed a commit
to Kazy/shuttle
that referenced
this pull request
Jun 23, 2023
…tle-hq#1040) * build(shell.nix): add openssl to nativeBuildInputs to fix build error related to missing openssl library
AlphaKeks
pushed a commit
to AlphaKeks/shuttle
that referenced
this pull request
Jul 21, 2023
…tle-hq#1040) * build(shell.nix): add openssl to nativeBuildInputs to fix build error related to missing openssl library
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
While building the client locally, it was complaining about missing openssl. Added it back and all is good.